Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMART on FHIR pt 2 - backend changes #452

Merged
merged 6 commits into from
Mar 25, 2025
Merged

SMART on FHIR pt 2 - backend changes #452

merged 6 commits into from
Mar 25, 2025

Conversation

nickclyde
Copy link
Member

@nickclyde nickclyde commented Mar 22, 2025

PULL REQUEST

Summary

Part two of SMART on FHIR implementation that implements backend functionality.

Related Issue

Follow up to #455 and part two of QUE-211

This includes the backend code for asymmetric key SMART on FHIR auth working as described in:

A forthcoming PR will propagate this new code into the frontend FHIR server modal

JWKS Generation Refactor:

Copy link

github-actions bot commented Mar 22, 2025

Coverage report for ./query-connector

St.
Category Percentage Covered / Total
🔴 Statements
59.43% (-3.46% 🔻)
1616/2719
🔴 Branches
49.89% (-3.16% 🔻)
454/910
🟡 Functions
62.77% (-1.22% 🔻)
344/548
🔴 Lines
59.19% (-3.68% 🔻)
1511/2553
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / lib.ts
5.8% 0% 0% 5.8%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / fhirClient.ts
18.1% (-59.67% 🔻)
7.69% (-42.31% 🔻)
45.45% (-21.21% 🔻)
16.67% (-58.33% 🔻)

Test suite run success

156 tests passing in 20 suites.

Report generated by 🧪jest coverage report action from 5dd0dde

@nickclyde nickclyde requested a review from fzhao99 March 24, 2025 05:03
@nickclyde nickclyde marked this pull request as ready for review March 24, 2025 05:09
@fzhao99 fzhao99 marked this pull request as draft March 24, 2025 13:30
@fzhao99 fzhao99 force-pushed the nickclyde/smart-backend branch from 87e3b5c to 8cd58aa Compare March 24, 2025 14:20
@fzhao99 fzhao99 changed the title SMART Asymmetric Key Implementation SMART on FHIR pt 2 - backend changes Mar 24, 2025
@fzhao99 fzhao99 force-pushed the nickclyde/smart-backend branch from 8cd58aa to ea37c4b Compare March 24, 2025 14:22
@fzhao99 fzhao99 changed the base branch from main to nickclyde/smart-db-and-infra March 24, 2025 14:22
@fzhao99 fzhao99 force-pushed the nickclyde/smart-backend branch 2 times, most recently from 3cfbae2 to d8c9d1f Compare March 24, 2025 14:28
@fzhao99 fzhao99 force-pushed the nickclyde/smart-backend branch 2 times, most recently from 9268950 to 5ec83a0 Compare March 24, 2025 14:48
Base automatically changed from nickclyde/smart-db-and-infra to main March 25, 2025 13:37
@fzhao99 fzhao99 marked this pull request as ready for review March 25, 2025 13:58
@fzhao99 fzhao99 force-pushed the nickclyde/smart-backend branch from c559b30 to 9fce88a Compare March 25, 2025 14:32
@fzhao99 fzhao99 force-pushed the nickclyde/smart-backend branch from 9fce88a to c4ff5ed Compare March 25, 2025 14:42
@fzhao99 fzhao99 merged commit 7b90ac5 into main Mar 25, 2025
14 of 15 checks passed
@fzhao99 fzhao99 deleted the nickclyde/smart-backend branch March 25, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants